LearnNewsExamplesServices
Frontmatter
id3492
titlelayout.Flexbox: only apply configs to `wrapperCls` in case there are changes
stateClosed
labels
enhancement
assigneestobiu
createdAtOct 2, 2022, 5:39 PM
updatedAtOct 2, 2022, 5:40 PM
githubUrlhttps://github.com/neomjs/neo/issues/3492
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 2, 2022, 5:40 PM

layout.Flexbox: only apply configs to wrapperCls in case there are changes

Closed v8.1.0 enhancement
tobiu
tobiu commented on Oct 2, 2022, 5:39 PM

this will reduce the afterSetWrapperCls() calls by a lot.

when creating a new layout, container.Base will trigger:

    afterSetLayout(value, oldValue) {
        let me = this;

        if (me.rendered) {
            oldValue.removeRenderAttributes();
            value.applyRenderAttributes();

            me.items.forEach((item, index) => {
                oldValue.removeChildAttributes(item, index);
                value.applyChildAttributes(item, index);
            });
        }
    }

=> the initial values will get applied anyway

tobiu added the enhancement label on Oct 2, 2022, 5:39 PM
tobiu assigned to @tobiu on Oct 2, 2022, 5:39 PM
tobiu referenced in commit a5ce7c4 - "layout.Flexbox: only apply configs to wrapperCls in case there are changes #3492" on Oct 2, 2022, 5:40 PM
tobiu closed this issue on Oct 2, 2022, 5:40 PM