LearnNewsExamplesServices
Frontmatter
id3510
titlebutton.Base: beforeSetIconCls() => the logic breaks in case we add spaces
stateClosed
labels
bug
assigneestobiu
createdAtOct 2, 2022, 10:07 PM
updatedAtOct 2, 2022, 10:09 PM
githubUrlhttps://github.com/neomjs/neo/issues/3510
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 2, 2022, 10:09 PM

button.Base: beforeSetIconCls() => the logic breaks in case we add spaces

Closed v8.1.0 bug
tobiu
tobiu commented on Oct 2, 2022, 10:07 PM

e.g. inside examples.tab.container.MainContainer when typing into the iconCls TextField => "fa ".

this will get converted into ['fa', ''].

we need to add a Boolean filter.

i will also cleanup afterSetIconCls().

tobiu added the bug label on Oct 2, 2022, 10:07 PM
tobiu assigned to @tobiu on Oct 2, 2022, 10:07 PM
tobiu referenced in commit 159598f - "button.Base: beforeSetIconCls() => the logic breaks in case we add spaces #3510" on Oct 2, 2022, 10:08 PM
tobiu closed this issue on Oct 2, 2022, 10:09 PM