LearnNewsExamplesServices
Frontmatter
id3625
titleNeo.data.Model should be renamed to something else, such as Neo.data.Record
stateClosed
labels
enhancementstale
assignees[]
createdAtDec 18, 2022, 12:30 AM
updatedAtSep 14, 2024, 4:26 AM
githubUrlhttps://github.com/neomjs/neo/issues/3625
authormaxrahder
commentsCount4
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 14, 2024, 4:26 AM

Neo.data.Model should be renamed to something else, such as Neo.data.Record

Closed v8.1.0 enhancementstale
maxrahder
maxrahder commented on Dec 18, 2022, 12:30 AM

"Model" is a highly overloaded term in programming, and even within Neo it can refer to a "view model" or a record class. When I talk to developers or in training, I always avoid using the term "model" since the audience may have preconceptions about what it means. Therefore, in Neo we need a different term. I suggest Neo.data.Record.

I do realize that a "record" is an instance, and stores are collections of records. But it's in OOP it's common for the instance to reflect the name of its class. For example, one defines a Neo.data.Store, and the instance is called a "store". There are numerous similar examples. I'd be tempted to call the record class Neo.data.Entity, as in "entity-relationship" (database) modeling, but "entity" is pretty ambigious too. I can't think of a better name than Ext.data.Record.

maxrahder added the enhancement label on Dec 18, 2022, 12:30 AM
tobiu
tobiu Dec 18, 2022, 12:28 PM

sounds like a discussion item for @ThorstenSuckow @ExtAnimal.

I do agree, that "model" for data & component models does sound a bit confusing.

However, records in neo are not model instances, but slightly enhanced objects (we need change events).

There is a Neo.data.RecordFactory in place, which would also create confusion with a record based naming.

Maybe Neo.data.Entity could work.

The bigger naming issue I see is that Angular & React devs got used to call a view model / state provider Store. In our world we automatically think of data.Store.

Open for ideas, in case we can make our namings easier. Needs to be bullet-proof :)

Dinkh
Dinkh Jan 2, 2023, 9:16 PM

I am fine with model, as it is only a model-description. Record would be the rendered data, based on the model-description.

For me there is no need to rename it.

@github-actions - 2024-08-30T02:27:32Z

This issue is stale because it has been open for 90 days with no activity.

  • 2024-08-30T02:27:33Z @github-actions added the stale label

@github-actions - 2024-09-14T02:26:34Z

This issue was closed because it has been inactive for 14 days since being marked as stale.

  • 2024-09-14T02:26:34Z @github-actions closed this issue