LearnNewsExamplesServices
Frontmatter
id365
titleCovid.view.MainContainerController: onHashChange() refactoring
stateClosed
labels
enhancementstale
assignees[]
createdAtMar 24, 2020, 8:35 PM
updatedAtSep 28, 2024, 4:31 AM
githubUrlhttps://github.com/neomjs/neo/issues/365
authortobiu
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 28, 2024, 4:31 AM

Covid.view.MainContainerController: onHashChange() refactoring

Closed v7.9.1/archive-v7-9-1-chunk-1 enhancementstale
tobiu
tobiu commented on Mar 24, 2020, 8:35 PM

there is a check in place if data got loaded and if not use a setTimeout() call.

this was just a quick hack.

onHashChange needs to store the params of its last call inside the class.

in case the api is loading or there is no data available => do nothing.

instead, when data got loaded, trigger onHashChange afterwards. Best with a 50-100ms delay to ensure the data got mounted into the real dom already.

tobiu added the enhancement label on Mar 24, 2020, 8:35 PM