LearnNewsExamplesServices
Frontmatter
id3678
titleViewport should default to autoMount: true
stateClosed
labels
enhancementgood first issue
assigneestobiu
createdAtDec 21, 2022, 8:04 PM
updatedAtJan 15, 2023, 10:46 PM
githubUrlhttps://github.com/neomjs/neo/issues/3678
authormaxrahder
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJan 15, 2023, 10:46 PM

Viewport should default to autoMount: true

Closed v8.1.0 enhancementgood first issue
maxrahder
maxrahder commented on Dec 21, 2022, 8:04 PM

Is there a use-case for autoMount:false? If that's the rare exception then Viewport should default that to true.

maxrahder added the enhancement label on Dec 21, 2022, 8:04 PM
tobiu
tobiu Dec 21, 2022, 8:43 PM

hi max, sounds good to me. feel free to send a PR.

tobiu added the good first issue label on Dec 21, 2022, 8:43 PM
tobiu assigned to @maxrahder on Dec 26, 2022, 6:46 PM
tobiu unassigned from @maxrahder on Jan 15, 2023, 10:30 PM
tobiu assigned to @tobiu on Jan 15, 2023, 10:31 PM
tobiu referenced in commit 0014cf1 - "Viewport should default to autoMount: true #3678" on Jan 15, 2023, 10:33 PM
tobiu referenced in commit d3df05e - "#3678 removing autoMount from the apps folder" on Jan 15, 2023, 10:40 PM
tobiu referenced in commit bce4cdc - "#3678 removing autoMount from the docs folder" on Jan 15, 2023, 10:40 PM
tobiu referenced in commit 1c46012 - "#3678 removing autoMount from the examples folder" on Jan 15, 2023, 10:45 PM
tobiu closed this issue on Jan 15, 2023, 10:46 PM