LearnNewsExamplesServices
Frontmatter
id3746
titlecontainer.Base: createItem() => removes default values
stateClosed
labels
bug
assigneestobiu
createdAtJan 3, 2023, 9:46 AM
updatedAtJan 3, 2023, 9:51 AM
githubUrlhttps://github.com/neomjs/neo/issues/3746
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJan 3, 2023, 9:47 AM

container.Base: createItem() => removes default values

Closed v8.1.0 bug
tobiu
tobiu commented on Jan 3, 2023, 9:46 AM

the check if an item has a module => removing the ntype and vice versa is getting applied to the itemDefaults object, so it will affect all following items.

we need to change this behavior to only change a shallow copy.

@Dinkh: this explains why window actions not always show up. the toolbar spacer is a module: Component, removes the default button ntype, actions become components and the styling is lost.

tobiu added the bug label on Jan 3, 2023, 9:46 AM
tobiu assigned to @tobiu on Jan 3, 2023, 9:46 AM
tobiu referenced in commit 3825927 - "container.Base: createItem() => removes default values #3746" on Jan 3, 2023, 9:46 AM
tobiu closed this issue on Jan 3, 2023, 9:47 AM
Dinkh
Dinkh Jan 3, 2023, 9:51 AM

lets add baseCls with this ticket.