LearnNewsExamplesServices
Frontmatter
id3862
titleNeo.applyClassConfig() => handle singletons and return the updates class or instance
stateClosed
labels
enhancement
assigneestobiu
createdAtJan 15, 2023, 2:38 AM
updatedAtJan 15, 2023, 9:34 AM
githubUrlhttps://github.com/neomjs/neo/issues/3862
authortobiu
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJan 15, 2023, 9:32 AM

Neo.applyClassConfig() => handle singletons and return the updates class or instance

Closed v8.1.0 enhancement
tobiu
tobiu commented on Jan 15, 2023, 2:38 AM

this will greatly reduce the code

tobiu added the enhancement label on Jan 15, 2023, 2:38 AM
tobiu assigned to @tobiu on Jan 15, 2023, 2:38 AM
tobiu referenced in commit 8112020 - "Neo.applyClassConfig() => handle singletons and return the updates class or instance #3862 src folder" on Jan 15, 2023, 2:38 AM
tobiu referenced in commit 79c68c0 - "#3862 data.RecordFactory fix => we need the reference to the instance" on Jan 15, 2023, 2:43 AM
tobiu
tobiu Jan 15, 2023, 8:56 AM

while the singleton changes are good, the default class changes decrease the performance due to the way module caching works. need to revert this part.

tobiu referenced in commit dfbc403 - "Revert "Neo.applyClassConfig() => handle singletons and return the updates class or instance #3862 src folder" on Jan 15, 2023, 8:56 AM
tobiu referenced in commit a0f62ae - "#3862 re-adding the singleton changes" on Jan 15, 2023, 9:17 AM
tobiu
tobiu Jan 15, 2023, 9:32 AM

did some more testing. it does not seem to affect the performance. however, the IDE support for non singleton based changes gets WAY worse:

Screenshot 2023-01-15 at 09 29 23
Screenshot 2023-01-15 at 09 29 42

i think we should just keep the current version.

tobiu closed this issue on Jan 15, 2023, 9:32 AM