LearnNewsExamplesServices
Frontmatter
id3875
titleSub label for Neo.form.field
stateClosed
labels
enhancement
assignees[]
createdAtJan 16, 2023, 1:40 PM
updatedAtJan 17, 2023, 12:13 PM
githubUrlhttps://github.com/neomjs/neo/issues/3875
authorki1pen
commentsCount3
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJan 17, 2023, 12:13 PM

Sub label for Neo.form.field

Closed v8.1.0 enhancement
ki1pen
ki1pen commented on Jan 16, 2023, 1:40 PM

Need sub label under the label for Neo.Form.Field Suggestion: Add a config subLabelText to write the sub label and subLabelStyle to add style and color

ki1pen added the enhancement label on Jan 16, 2023, 1:40 PM
ki1pen changed title from Sub label for Neo.Form.Field to Sub label for Neo.form.field on Jan 16, 2023, 1:40 PM
tobiu
tobiu Jan 17, 2023, 8:33 AM

Hi Kiattipoom!

I will start with form.field.Text, which will also include the feature for DateFields, PickerFields & SelectFields.

Do we need this for checkboxes and radios as well?

TextFields have 5 different labelPositions => top, right, bottom, left & inline. I think we do need to limit the new config to only get used for the top position. I guess bottom could work too.

Thoughts?

tobiu referenced in commit ea3c4a5 - "#3875 form.field.Text: subLabel_" on Jan 17, 2023, 9:24 AM
tobiu referenced in commit 42dcbc2 - "#3875 form.field.Text: afterSetTriggers() fix, added the new config into the TextField example" on Jan 17, 2023, 9:29 AM
ki1pen
ki1pen Jan 17, 2023, 9:37 AM

form.field.Text should be enough for now. Top and bottom labelPositions work. But most of the use case would be top labelPosition.

tobiu referenced in commit 2933343 - "#3875 form.field.Text: subLabelBaseCls, subLabelCls_" on Jan 17, 2023, 10:45 AM
tobiu referenced in commit 8602284 - "#3875 form.field.Range: adjusted the logic to honor subLabelText nodes" on Jan 17, 2023, 10:46 AM
tobiu referenced in commit 3d4c76d - "#3875 form.field.Text: styling src, theme-light" on Jan 17, 2023, 10:56 AM
tobiu referenced in commit 2da16e5 - "#3875 form.field.Text: theme-dark" on Jan 17, 2023, 11:00 AM
tobiu referenced in commit eb2dcdd - "#3875 form.field.Text: afterSetLabelPosition() hiding a subLabel, in case the position is not top." on Jan 17, 2023, 12:12 PM
tobiu
tobiu Jan 17, 2023, 12:13 PM

finished the support for position top. i think we can ignore bottom.

Screenshot 2023-01-17 at 10 55 54
tobiu closed this issue on Jan 17, 2023, 12:13 PM
ki1pen closed this issue on Jan 17, 2023, 1:38 PM