LearnNewsExamplesServices
Frontmatter
id3903
titlecontroller.Base: examine why the observable mixin is included
stateClosed
labels
enhancement
assignees[]
createdAtJan 18, 2023, 10:23 PM
updatedAtJan 18, 2023, 10:34 PM
githubUrlhttps://github.com/neomjs/neo/issues/3903
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJan 18, 2023, 10:34 PM

controller.Base: examine why the observable mixin is included

Closed v8.1.0 enhancement
tobiu
tobiu commented on Jan 18, 2023, 10:23 PM

Can't remember anymore why the mixin got there. At a first glance, especially view controllers should only fire events on views.

An application instance (which does extend controller.Base) might need it, but this child class could include the mixin on its own.

tobiu added the enhancement label on Jan 18, 2023, 10:23 PM
tobiu referenced in commit ca98e3f - "controller.Base: examine why the observable mixin is included #3903" on Jan 18, 2023, 10:34 PM
tobiu
tobiu Jan 18, 2023, 10:34 PM

just moved the mixin to app. we could revert it, in case there are reasons which make sense.

tobiu closed this issue on Jan 18, 2023, 10:34 PM