LearnNewsExamplesServices
Frontmatter
id4040
titlecomponent.Base: show() with hideMode: ''removeDom''
stateClosed
labels
bug
assigneestobiu
createdAtFeb 12, 2023, 10:52 PM
updatedAtFeb 12, 2023, 11:48 PM
githubUrlhttps://github.com/neomjs/neo/issues/4040
authortobiu
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtFeb 12, 2023, 11:48 PM

component.Base: show() with hideMode: 'removeDom'

Closed v8.1.0 bug
tobiu
tobiu commented on Feb 12, 2023, 10:52 PM

i tested this on various scenarios e.g. examples.button.split to hide a trigger and it did not work for me.

removeDom relies a bit on toggling on / off for child nodes. in case we want the root though, we would most likely need to trigger an update on the parent component, in case it exists.

the probably easier way which should work is using render(true) instead of update().

@Dinkh can you please double-check this change. Especially on your own apps in case you are not using a different hideMode there.

thx!

tobiu added the bug label on Feb 12, 2023, 10:52 PM
tobiu assigned to @tobiu on Feb 12, 2023, 10:52 PM
tobiu referenced in commit a393c75 - "component.Base: show() with hideMode: 'removeDom' #4040" on Feb 12, 2023, 10:52 PM
tobiu
tobiu Feb 12, 2023, 10:53 PM

closing the ticket. we can definitely re-open it in case this is needed.

tobiu closed this issue on Feb 12, 2023, 10:53 PM
tobiu
tobiu Feb 12, 2023, 11:47 PM

well, i did forget the "silent mode".

tobiu reopened this issue on Feb 12, 2023, 11:47 PM
tobiu referenced in commit 67b49f5 - "#4040 do not re-mount in silent mode" on Feb 12, 2023, 11:48 PM
tobiu closed this issue on Feb 12, 2023, 11:48 PM