LearnNewsExamplesServices
Frontmatter
id4059
titlenew variables for tab-->header-->button.scss
stateClosed
labels
enhancement
assignees[]
createdAtFeb 15, 2023, 1:57 PM
updatedAtFeb 17, 2023, 9:59 AM
githubUrlhttps://github.com/neomjs/neo/issues/4059
authorMRHajari
commentsCount4
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtFeb 17, 2023, 9:59 AM

new variables for tab-->header-->button.scss

Closed v8.1.0 enhancement
MRHajari
MRHajari commented on Feb 15, 2023, 1:57 PM

These variables are missing in the theme tab-->header-->button.scss. please add those. 'tab-button-background-color'
'tab-button-background-color-active'
'tab-button-background-color-disabled'
'tab-button-background-color-hover'
'tab-button-gap'
'tab-button-height-active'
'tab-button-height-disabled'
'tab-button-width'
'tab-button-padding-active'
'tab-button-padding-disabled'

MRHajari added the enhancement label on Feb 15, 2023, 1:57 PM
tobiu
tobiu Feb 15, 2023, 2:45 PM

i am not sure about tab-button-width => a tab should adjust to the width of its content. e.g. inside our forms we have use cases where a tab header only contains a number like 1, 2, 3. if there was a fixed (minimum?) width on theme level, they might get too wide.

we can still change widths on JS level.

thoughts? @mxmrtns

tobiu
tobiu Feb 15, 2023, 2:48 PM

actually one more question: can a tab header button padding change for different states? i imagine that this could break the layout.

MRHajari
MRHajari Feb 15, 2023, 4:35 PM

You're right. can we have tab-button-minWidth?

tobiu referenced in commit a6f95c1 - "#4059 tab-button-background-color" on Feb 16, 2023, 9:16 PM
tobiu referenced in commit b6b1a70 - "#4059 tab-button-background-color-active" on Feb 16, 2023, 9:20 PM
tobiu referenced in commit bd1f2cf - "#4059 tab-button-background-color-active polishing" on Feb 16, 2023, 9:27 PM
tobiu referenced in commit 6ed702c - "#4059 tab-button-background-color-active polishing" on Feb 16, 2023, 9:28 PM
tobiu referenced in commit 3ce99da - "#4059 tab-button-background-color-disabled" on Feb 16, 2023, 9:39 PM
tobiu referenced in commit 843d4a8 - "#4059 tab-button-background-color-hover" on Feb 16, 2023, 10:25 PM
tobiu referenced in commit 1b4da5d - "#4059 tab-button-height" on Feb 16, 2023, 10:29 PM
tobiu referenced in commit a983067 - "#4059 tab-button-text-height-pressed" on Feb 16, 2023, 10:36 PM
tobiu referenced in commit 1365555 - "#4059 ensuring that tab indicator styles get a prio again" on Feb 16, 2023, 10:43 PM
tobiu referenced in commit 2418092 - "#4059 tab-button-height-pressed: support for dock top & bottom" on Feb 16, 2023, 10:50 PM
tobiu referenced in commit 4a03113 - "#4059 tab-button-height-pressed: support for dock left & right" on Feb 16, 2023, 10:53 PM
tobiu referenced in commit 66d6049 - "#4059 tab.header.Toolbar: fixed sizes for all position to ensure that they don't get "jumpy" when switching the pressed button with a different height / width" on Feb 16, 2023, 11:02 PM
tobiu referenced in commit dd504fa - "#4059 tab-button-height-pressed: resetted to the default value" on Feb 16, 2023, 11:03 PM
tobiu referenced in commit 8961d45 - "#4059 tab-button-padding" on Feb 16, 2023, 11:08 PM
tobiu referenced in commit 640c160 - "#4059 tab-button-glyph-color-over => tab-button-glyph-color-hover" on Feb 16, 2023, 11:10 PM
tobiu referenced in commit 8837ffc - "#4059 tab-button-gap" on Feb 16, 2023, 11:26 PM
tobiu
tobiu Feb 17, 2023, 9:59 AM

to give you guys an update:

Screenshot 2023-02-16 at 22 44 46

Screenshot 2023-02-16 at 23 27 07
Screenshot 2023-02-16 at 23 16 41
Screenshot 2023-02-16 at 23 19 43

some of the variables took quite some effort, since we do have 4 different header positions in place.

drag&drop ops do not honor the potential gap yet, i will create a follow up ticket for this one.

in general: tabs should use one of the button uis (secondary or ghost i guess), so we can define this one inside the Overwrites.mjs inside an app.

since tab header buttons are extending button and use their CSS rules, a tab button itself should only contain additional logic on top. so i am not 100% sure if we should keep e.g. background-colors for different states.

tobiu closed this issue on Feb 17, 2023, 9:59 AM