LearnNewsExamplesServices
Frontmatter
id4305
titleform.field.Text: afterSetRequired(), afterSetValue() => only set silentVdomUpdate to false in case it was not true outside of this scope
stateClosed
labels
bug
assigneestobiu
createdAtApr 20, 2023, 2:38 PM
updatedAtApr 20, 2023, 6:06 PM
githubUrlhttps://github.com/neomjs/neo/issues/4305
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtApr 20, 2023, 6:06 PM

form.field.Text: afterSetRequired(), afterSetValue() => only set silentVdomUpdate to false in case it was not true outside of this scope

Closed v8.1.0 bug
tobiu
tobiu commented on Apr 20, 2023, 2:38 PM

example: bulk config updates where we want to prevent updates until all of them are done.

setting the config to false earlier will result in multiple engine calls.

tobiu added the bug label on Apr 20, 2023, 2:38 PM
tobiu assigned to @tobiu on Apr 20, 2023, 2:38 PM
tobiu
tobiu Apr 20, 2023, 3:30 PM

actually we can and should resolve this in a more generic way, using beforeSetVdomUpdate() to change the value into an integer. each additional set to true increases it further, zero enables updates again.

this.silentVdomUpdate = true; // 1
this.silentVdomUpdate = true; // 2

this.silentVdomUpdate = false; // 1 => not re-enabling updates this.silentVdomUpdate = false; // 0 => updates enabled again

tobiu referenced in commit e45ad78 - "#4305 silentVdomUpdate => silentVdomUpdate_" on Apr 20, 2023, 6:06 PM
tobiu closed this issue on Apr 20, 2023, 6:06 PM