Frontmatter
| id | 4490 |
| title | util.StringUtil cleanup |
| state | Closed |
| labels | enhancement |
| assignees | [] |
| createdAt | May 31, 2023, 6:21 PM |
| updatedAt | Sep 26, 2024, 2:34 PM |
| githubUrl | https://github.com/neomjs/neo/issues/4490 |
| author | tobiu |
| commentsCount | 2 |
| parentIssue | null |
| subIssues | [] |
| subIssuesCompleted | 0 |
| subIssuesTotal | 0 |
| blockedBy | [] |
| blocking | [] |
| closedAt | Jun 26, 2023, 3:19 PM |
util.StringUtil cleanup
tobiu assigned to @Ghost on Jun 19, 2023, 11:17 AM
Ghost cross-referenced by PR #4513 on Jun 24, 2023, 5:37 PM
tobiu closed this issue on Jun 26, 2023, 10:36 AM
tobiu
Jun 26, 2023, 3:13 PM
i will add a bit more polishing:
- static configs order & comments
- method order
- static regex => new ctor not needed
tobiu reopened this issue on Jun 26, 2023, 3:13 PM
tobiu
Jun 26, 2023, 3:19 PM
done now.
@dztoprak since there are many dependencies between static methods and static configs, another way to implement this would be converting the class into a singleton. example: https://github.com/neomjs/neo/blob/dev/src/util/Logger.mjs#L29
feel free to create a follow-up ticket, in case you like the singleton idea better.
tobiu closed this issue on Jun 26, 2023, 3:19 PM
We should order the methods according to our coding guidelines:
We could also cache the regex inside
unescapeHtml()into a static class field.