LearnNewsExamplesServices
Frontmatter
id4498
titlecore.Base: parseItemConfigs() => exclude neo classes
stateClosed
labels
enhancementstale
assigneestobiu
createdAtJun 9, 2023, 5:02 PM
updatedAtSep 13, 2024, 4:29 AM
githubUrlhttps://github.com/neomjs/neo/issues/4498
authortobiu
commentsCount3
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 13, 2024, 4:29 AM

core.Base: parseItemConfigs() => exclude neo classes

Closed v8.1.0 enhancementstale
tobiu
tobiu commented on Jun 9, 2023, 5:02 PM

we can use imported modules directly inside container items. in this case, parseItemConfigs() can iterate over static class fields, which is not intended (and could even cause issues).

tobiu added the enhancement label on Jun 9, 2023, 5:02 PM
tobiu assigned to @tobiu on Jun 9, 2023, 5:02 PM
tobiu referenced in commit d2b0960 - "core.Base: parseItemConfigs() => exclude neo classes #4498" on Jun 9, 2023, 5:03 PM
tobiu closed this issue on Jun 9, 2023, 5:03 PM
tobiu referenced in commit 4c25a39 - "core.Base: parseItemConfigs() => exclude neo classes #4498" on Jun 12, 2023, 10:30 AM
tobiu
tobiu Jun 19, 2023, 3:15 PM

unfortunately, we need to re-open this one. the change is breaking the docs app and also affects a huge client app.

tobiu reopened this issue on Jun 19, 2023, 3:15 PM
tobiu referenced in commit 83759b5 - "#4498 reverting the parseItemConfigs() exclusion for now" on Jun 19, 2023, 3:16 PM