LearnNewsExamplesServices
Frontmatter
id4511
titleMake border !important
stateClosed
labels[]
assignees[]
createdAtJun 19, 2023, 6:05 PM
updatedAtAug 1, 2023, 12:09 AM
githubUrlhttps://github.com/neomjs/neo/issues/4511
authormxmrtns
commentsCount3
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtAug 1, 2023, 12:09 AM

Make border !important

Closed v8.1.0 []
mxmrtns
mxmrtns commented on Jun 19, 2023, 6:05 PM

https://github.com/neomjs/neo/blob/63bc6a6a00b069733f11c69645b5b0d17000ff83/resources/scss/src/button/Base.scss#LL159C3-L159C3

The border property from the ghost button is currently overwritten by the border from .neo-button:active

mxmrtns changed title from Change border to outline to Make border !important on Jun 19, 2023, 6:22 PM
mxmrtns
mxmrtns Jul 31, 2023, 7:56 PM

@tobiu This is till an issue for every button style that does not want to use a border (in my case tertiary and ghost).

Is it possible to remove the "!important" from the default active state?

&:active { border : v(button-border-active) !important; change to → &:active { border : v(button-border-active) ;

tobiu
tobiu Aug 1, 2023, 12:07 AM

hi max! this ticket fell under the radar :)

i think the !important was intended to give the active boder a prio over error css (e.g. a red border). need to double-check if we can remove it without breaking this order.

however, you are right: only the primary ui has the important flag, all others don't. so we could also just add the flag into the other uis and should be good.

tobiu referenced in commit 474c4b3 - "Make border !important #4511" on Aug 1, 2023, 12:08 AM
tobiu
tobiu Aug 1, 2023, 12:09 AM

let's try, if this quick-fix already does the trick. if not, we can re-open the issue.

tobiu closed this issue on Aug 1, 2023, 12:09 AM