LearnNewsExamplesServices
Frontmatter
id4532
titlelayout.Flexbox: afterSetGap()
stateClosed
labels
bug
assigneesDinkh
createdAtJul 10, 2023, 3:26 PM
updatedAtJul 10, 2023, 4:18 PM
githubUrlhttps://github.com/neomjs/neo/issues/4532
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJul 10, 2023, 4:18 PM

layout.Flexbox: afterSetGap()

Closed v8.1.0 bug
tobiu
tobiu commented on Jul 10, 2023, 3:26 PM

without testing it, i think this line has a potential for errors: if (!value && !oldValue) return;

if you change the gap from e.g. "5px" to null or vice versa, nothing will happen.

tobiu added the bug label on Jul 10, 2023, 3:26 PM
tobiu assigned to @Dinkh on Jul 10, 2023, 3:26 PM
tobiu
tobiu Jul 10, 2023, 4:16 PM

actually not true, since both have a !. so it will just return for undefined and null combos. i will fix the formatting and close the ticket.

tobiu referenced in commit d05233a - "layout.Flexbox: afterSetGap() #4532 => formatting" on Jul 10, 2023, 4:17 PM
tobiu closed this issue on Jul 10, 2023, 4:18 PM