Frontmatter
| id | 4552 |
| title | component.Video: cleanup |
| state | Closed |
| labels | enhancement |
| assignees | Dinkh |
| createdAt | Jul 17, 2023, 5:09 PM |
| updatedAt | Jul 31, 2024, 10:49 PM |
| githubUrl | https://github.com/neomjs/neo/issues/4552 |
| author | tobiu |
| commentsCount | 2 |
| parentIssue | null |
| subIssues | [] |
| subIssuesCompleted | 0 |
| subIssuesTotal | 0 |
| blockedBy | [] |
| blocking | [] |
| closedAt | Jul 31, 2024, 10:49 PM |
component.Video: cleanup
tobiu assigned to @Dinkh on Jul 17, 2023, 5:09 PM
Dinkh
Jul 31, 2024, 9:54 PM
autoplay is used to immediately start playing the video, when you click the ghost. I will add a autoplay functionality anyways.
Dinkh
Jul 31, 2024, 10:49 PM
fixed and added autoplay
Dinkh closed this issue on Jul 31, 2024, 10:49 PM
hi torsten,
a couple of thoughts:
in case you are not using the vdom reference, don't assign it to a variable. we can use
this.update()instead ofthis.vdom = vdom. already changed in all other spots inside the framework. example: https://github.com/neomjs/neo/blob/dev/src/button/Base.mjs#L169same pattern for domListeners =>
this.addDomListeners()example: https://github.com/neomjs/neo/blob/dev/src/button/Base.mjs#L181the
playing_config defaults to false. on DOM level there isautoplay: truethough. i guess autoPlay could be a config on its own.please drop a comment in case you want me to add the changes.