LearnNewsExamplesServices
Frontmatter
id4571
titlebutton.Base: domListeners refactoring
stateClosed
labels
enhancement
assigneestobiu
createdAtJul 25, 2023, 11:02 PM
updatedAtJul 26, 2023, 2:43 PM
githubUrlhttps://github.com/neomjs/neo/issues/4571
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJul 26, 2023, 2:43 PM

button.Base: domListeners refactoring

Closed v8.1.0 enhancement
tobiu
tobiu commented on Jul 25, 2023, 11:02 PM

while the domListeners won't end up inside the DOM, at this point we have up to 4 add calls.

instead, we should just add one listener pointing to a new class method like onClick(), which can then execute the handler, route, rippleEffect and menu toggle as needed.

tobiu added the enhancement label on Jul 25, 2023, 11:02 PM
tobiu assigned to @tobiu on Jul 25, 2023, 11:02 PM
tobiu referenced in commit c14d638 - "button.Base: domListeners refactoring #4571" on Jul 26, 2023, 1:01 PM
tobiu referenced in commit d49944a - "#4571 button.Base: domListeners refactoring" on Jul 26, 2023, 2:43 PM
tobiu closed this issue on Jul 26, 2023, 2:43 PM