LearnNewsExamplesServices
Frontmatter
id4595
titleadd "icon", "label", "anchorPoint" fields, etc to Neo.main.addon.GoogleMaps.addMarker(data)
stateClosed
labels
enhancement
assignees[]
createdAtJul 30, 2023, 1:11 AM
updatedAtJul 30, 2023, 11:13 PM
githubUrlhttps://github.com/neomjs/neo/issues/4595
authorgplanansky
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJul 30, 2023, 11:13 PM

add "icon", "label", "anchorPoint" fields, etc to Neo.main.addon.GoogleMaps.addMarker(data)

Closed v8.1.0 enhancement
gplanansky
gplanansky commented on Jul 30, 2023, 1:11 AM

The GoogleMaps legacy marker implements fields beyond the "title" and "position". https://developers.google.com/maps/documentation/javascript/reference/marker#MarkerOptions

The icon, label fields are useful. (Neo examples/component/wrapper/GoogleMaps/ MapComponent.mjs already codes icons, but addon omits them.)

line 95 ff src/main/addon/GoogleMaps.mjs 

  position: data.position,
  title       : data.title,
  icon       : data.icon,  // add these
  label      : data.label,
  etc.

gplanansky added the enhancement label on Jul 30, 2023, 1:11 AM
tobiu referenced in commit da8654e - "add "icon", "label", "anchorPoint" fields, etc to Neo.main.addon.GoogleMaps.addMarker(data) #4595" on Jul 30, 2023, 11:05 PM
tobiu referenced in commit fa071d1 - "add "icon", "label", "anchorPoint" fields, etc to Neo.main.addon.GoogleMaps.addMarker(data) #4595" on Jul 30, 2023, 11:08 PM
tobiu referenced in commit 77bf802 - "#4595 component.wrapper.GoogleMaps: added anchorPoint to the model definition" on Jul 30, 2023, 11:09 PM
tobiu
tobiu Jul 30, 2023, 11:13 PM

added the 3

tobiu closed this issue on Jul 30, 2023, 11:13 PM