LearnNewsExamplesServices
Frontmatter
id4608
titleThis Styling overwrites project styling for inputFields:focus
stateClosed
labels[]
assignees[]
createdAtJul 31, 2023, 3:45 PM
updatedAtJul 31, 2023, 4:18 PM
githubUrlhttps://github.com/neomjs/neo/issues/4608
authormarkusmorley-s2
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJul 31, 2023, 4:18 PM

This Styling overwrites project styling for inputFields:focus

Closed v8.1.0 []
markusmorley-s2
markusmorley-s2 commented on Jul 31, 2023, 3:45 PM

https://github.com/neomjs/neo/blob/594ca2e1a6e5efd728b1406a496b456b1d46b2b2/resources/scss/src/form/field/Text.scss#L351

if i comment this out in my local nodeModules and run build-themes it work like expected // &:focus { // outline : none; // }

tobiu
tobiu Jul 31, 2023, 3:54 PM

the following rule is there by design: .neo-textfield-input defined on its own, is not aware if it is nested inside a wrapper containing triggers. we obviously do want that the focus outline covers the entire field component.

once an input node receives focus, neo will add neo-focus as a selector to the top level node of the field component.

in case there is a wrapper involved, the following rule will get applied: https://github.com/neomjs/neo/blob/594ca2e1a6e5efd728b1406a496b456b1d46b2b2/resources/scss/src/form/field/Text.scss#L12

in case there are no triggers, the rule: https://github.com/neomjs/neo/blob/594ca2e1a6e5efd728b1406a496b456b1d46b2b2/resources/scss/src/form/field/Text.scss#L27

should get a prio over the rule you mentioned (more specific selector).

i recommend to take a closer look by inspecting the DOM for the rules which get applied, to figure out if & where a change is required.

tobiu referenced in commit e94b742 - "This Styling overwrites project styling for inputFields:focus #4608" on Jul 31, 2023, 4:18 PM
tobiu
tobiu Jul 31, 2023, 4:18 PM

added !important to ensure the higher prio. will get into the next release.

tobiu closed this issue on Jul 31, 2023, 4:18 PM