LearnNewsExamplesServices
Frontmatter
id4612
titleVariables for popover menu
stateClosed
labels
enhancement
assignees[]
createdAtJul 31, 2023, 6:05 PM
updatedAtAug 3, 2023, 11:28 PM
githubUrlhttps://github.com/neomjs/neo/issues/4612
authormxmrtns
commentsCount4
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtAug 3, 2023, 11:28 PM

Variables for popover menu

Closed v8.1.0 enhancement
mxmrtns
mxmrtns commented on Jul 31, 2023, 6:05 PM

For styling this component, we would need the following variables.

Menu Item

  • height

  • padding

  • gap (something to control the distance between the icons and text)

  • font-familiy, color, font-weight, line-height, text-transform

  • font-color and icon color for disabled state

  • background-color

  • background-color-hover

  • background-color-pressed

  • background-color-disabled

-outlined-focused

mxmrtns added the enhancement label on Jul 31, 2023, 6:05 PM
tobiu
tobiu Aug 1, 2023, 12:39 AM

i guess i should have mentioned that menu.List is extending list.Base which already has some of them :)

well, unless we do want different styling for lists when they are inside floating containers.

tobiu referenced in commit 34f2315 - "Variables for popover menu #4612 (in progress)" on Aug 1, 2023, 12:49 AM
tobiu
tobiu Aug 1, 2023, 12:50 AM

added around half of them. let's connect tomorrow to figure out, if modifying list.Base instead is smarter.

tobiu referenced in commit 035c209 - "Variables for popover menu #4612" on Aug 3, 2023, 11:06 PM
tobiu
tobiu Aug 3, 2023, 11:13 PM

i assume that "pressed" should mean "selected". unless you want a ripple effect or a different state onMouseDown (which is different to the selected look and vanishes onMouseUp).

tobiu referenced in commit f1e9733 - "Variables for popover menu #4612" on Aug 3, 2023, 11:28 PM
tobiu
tobiu Aug 3, 2023, 11:28 PM

i think i got them all now.

tobiu closed this issue on Aug 3, 2023, 11:28 PM