LearnNewsExamplesServices
Frontmatter
id4836
titleNeo.tree.Accordion: onStoreRecordChange doesn''t change icon
stateClosed
labels
bug
assignees[]
createdAtSep 4, 2023, 5:27 PM
updatedAtSep 4, 2023, 5:36 PM
githubUrlhttps://github.com/neomjs/neo/issues/4836
authorGhost
commentsCount3
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 4, 2023, 5:36 PM

Neo.tree.Accordion: onStoreRecordChange doesn't change icon

Closed v8.1.0 bug
Ghost
Ghost commented on Sep 4, 2023, 5:27 PM

In Neo.tree.Accordion component:

itemVdom = VDomUtil.getByFlag(vdom, field.name);

doesn't find the vdom because the flag is named incorrectly. Instead of flag: "icon", it should be flag: "iconCls";

Ghost added the bug label on Sep 4, 2023, 5:27 PM
tobiu
tobiu Sep 4, 2023, 5:28 PM

do you want to send a PR or should @Dinkh look into it?

Ghost
Ghost Sep 4, 2023, 5:30 PM

@pensuwan-k has done the change, will open the PR in a while.

  • 2023-09-04T15:31:34Z @pensuwan-k referenced in commit 1e7bc28 - "#4836 Change the flag name"
  • 2023-09-04T15:33:03Z @pensuwan-k cross-referenced by PR #4837
tobiu referenced in commit ba77e21 - "Merge pull request #4837 from pensuwan-k/dev on Sep 4, 2023, 5:34 PM
tobiu
tobiu Sep 4, 2023, 5:36 PM

created a new release for you: https://github.com/neomjs/neo/releases/tag/6.3.3

tobiu closed this issue on Sep 4, 2023, 5:36 PM