LearnNewsExamplesServices
Frontmatter
id4867
titlebutton.Base: destroy()
stateClosed
labels
enhancement
assigneestobiu
createdAtSep 10, 2023, 10:14 PM
updatedAtSep 10, 2023, 10:33 PM
githubUrlhttps://github.com/neomjs/neo/issues/4867
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 10, 2023, 10:33 PM

button.Base: destroy()

Closed v8.1.0 enhancement
tobiu
tobiu commented on Sep 10, 2023, 10:14 PM

since we added the menu config, we should also destroy the related menu instance when destroying the button (in case it exists).

tobiu added the enhancement label on Sep 10, 2023, 10:14 PM
tobiu referenced in commit cd4390c - "button.Base: destroy() #4867" on Sep 10, 2023, 10:31 PM
tobiu closed this issue on Sep 10, 2023, 10:31 PM
tobiu assigned to @tobiu on Sep 10, 2023, 10:32 PM
tobiu
tobiu Sep 10, 2023, 10:33 PM

we can remove the collection destroy() change => was caused via calling destroy() 2x on the store.

tobiu reopened this issue on Sep 10, 2023, 10:33 PM
tobiu referenced in commit 40df7d4 - "button.Base: destroy() #4867" on Sep 10, 2023, 10:33 PM
tobiu closed this issue on Sep 10, 2023, 10:33 PM
tobiu referenced in commit 692bcf6 - "v6.4.0 (#4882) on Sep 11, 2023, 4:00 PM