LearnNewsExamplesServices
Frontmatter
id4870
titlecomponent.Base: isVdomUpdating change does not honor render
stateClosed
labels
bug
assigneesExtAnimal
createdAtSep 10, 2023, 11:07 PM
updatedAtSep 11, 2023, 7:11 AM
githubUrlhttps://github.com/neomjs/neo/issues/4870
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 11, 2023, 7:11 AM

component.Base: isVdomUpdating change does not honor render

Closed v8.1.0 bug
tobiu
tobiu commented on Sep 10, 2023, 11:07 PM

Hi Nige,

I am wondering about this change:

Screenshot 2023-09-10 at 22 58 12

We also set this flag to true when calling render(). This is important, since updates which arrive while the initial rendering cycle is running need to get delayed.

If you want to keep:

    get isVdomUpdating() {
        // The VDOM is being updated if we have the promise that executeVdomUpdate uses
        return Boolean(this.vdomUpdate)
    }

we need to adjust all setters to modify this.vdomUpdate to a promise or null instead.

tobiu added the bug label on Sep 10, 2023, 11:07 PM
tobiu assigned to @ExtAnimal on Sep 10, 2023, 11:07 PM
tobiu
tobiu Sep 10, 2023, 11:11 PM

the alternative is to restore the old way how it worked.

ExtAnimal closed this issue on Sep 11, 2023, 7:11 AM
tobiu referenced in commit 692bcf6 - "v6.4.0 (#4882) on Sep 11, 2023, 4:00 PM
ki1pen referenced in commit d805987 - "Fix https://github.com/neomjs/neo/issues/4870" on Mar 1, 2024, 5:55 AM