LearnNewsExamplesServices
Frontmatter
id4873
titlebutton.Base: switching themes for the menu
stateClosed
labels
enhancement
assigneestobiu
createdAtSep 11, 2023, 11:43 AM
updatedAtSep 11, 2023, 12:15 PM
githubUrlhttps://github.com/neomjs/neo/issues/4873
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 11, 2023, 12:15 PM

button.Base: switching themes for the menu

Closed v8.1.0 enhancement
tobiu
tobiu commented on Sep 11, 2023, 11:43 AM
Screenshot 2023-09-11 at 11 02 37

we need to get to this state.

right now, button.Base is rendering menus into the document.body, while menu.List renders sub menus into the viewport. we should adjust this part to be consistent.

if we go for document.body, we need to adjust examples.ConfigurationViewport to switch the theme there instead of the viewport.

tobiu added the enhancement label on Sep 11, 2023, 11:43 AM
tobiu assigned to @tobiu on Sep 11, 2023, 11:43 AM
tobiu referenced in commit 1bc3ce2 - "#4873 examples.ConfigurationViewport: onSwitchTheme() => applying changes to the document.body" on Sep 11, 2023, 12:15 PM
tobiu closed this issue on Sep 11, 2023, 12:15 PM
tobiu referenced in commit 692bcf6 - "v6.4.0 (#4882) on Sep 11, 2023, 4:00 PM