LearnNewsExamplesServices
Frontmatter
id4883
titlemenu.List: re-add onItemClick()
stateClosed
labels
bug
assigneestobiu
createdAtSep 11, 2023, 4:44 PM
updatedAtSep 11, 2023, 4:45 PM
githubUrlhttps://github.com/neomjs/neo/issues/4883
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 11, 2023, 4:45 PM

menu.List: re-add onItemClick()

Closed v8.1.0 bug
tobiu
tobiu commented on Sep 11, 2023, 4:44 PM

@ExtAnimal: we had the issue with menus showing up twice. removing the click handler entirely was a bad call, since this also removes handlers & routes for menu items.

i will add it back, plus adjust showSubMenu() to only render & mount in case there is a real change. this should also prevent the duplication.

tobiu added the bug label on Sep 11, 2023, 4:44 PM
tobiu assigned to @tobiu on Sep 11, 2023, 4:44 PM
tobiu referenced in commit 7b91928 - "menu.List: re-add onItemClick() #4883" on Sep 11, 2023, 4:45 PM
tobiu closed this issue on Sep 11, 2023, 4:45 PM
tobiu referenced in commit a32c98d - "v6.4.1 (#4884) on Sep 11, 2023, 4:56 PM
tobiu cross-referenced by PR #4885 on Sep 11, 2023, 4:57 PM
tobiu referenced in commit 8d2285a - "v6.4.1 (#4884) (#4885) on Sep 11, 2023, 4:57 PM