LearnNewsExamplesServices
Frontmatter
id4948
titledraggable.toolbar.SortZone: switchItems() => regression issue
stateClosed
labels
bug
assigneestobiu
createdAtSep 27, 2023, 6:58 PM
updatedAtSep 27, 2023, 9:36 PM
githubUrlhttps://github.com/neomjs/neo/issues/4948
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 27, 2023, 9:36 PM

draggable.toolbar.SortZone: switchItems() => regression issue

Closed v8.1.0 bug
tobiu
tobiu commented on Sep 27, 2023, 6:58 PM

the change inside component.Base: getDomRect() which is now returning a util.Rectangle instance, introduced a new bug, since DOMRects are not spreadable.

will look into it now (we do have clone())

@ExtAnimal

blocking https://github.com/neomjs/neo/issues/4767

tobiu added the bug label on Sep 27, 2023, 6:58 PM
tobiu assigned to @tobiu on Sep 27, 2023, 6:58 PM
tobiu changed title from draggable.toolbar.DragZone: switchItems() => regression issue to draggable.toolbar.SortZone: switchItems() => regression issue on Sep 27, 2023, 7:20 PM
tobiu referenced in commit aae132f - "draggable.toolbar.SortZone: switchItems() => regression issue #4948" on Sep 27, 2023, 9:35 PM
tobiu
tobiu Sep 27, 2023, 9:36 PM

DOMRect instances are leaving left & top as readOnly, so i switched to x and y.

tobiu closed this issue on Sep 27, 2023, 9:36 PM
tobiu referenced in commit d91c921 - "v6.7.3 (#4954) on Sep 28, 2023, 12:55 PM