LearnNewsExamplesServices
Frontmatter
id4950
titlecomponent.Base: getDomRect() => inconsistent return values
stateClosed
labels
bug
assigneestobiu
createdAtSep 27, 2023, 8:19 PM
updatedAtSep 27, 2023, 8:20 PM
githubUrlhttps://github.com/neomjs/neo/issues/4950
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 27, 2023, 8:20 PM

component.Base: getDomRect() => inconsistent return values

Closed v8.1.0 bug
tobiu
tobiu commented on Sep 27, 2023, 8:19 PM

actually i was not aware that we can now convert DOMRects into JSON. even both ways => we do get them back inside the app worker.

getDomRect() inside the app worker now returns DOMRect instances for arrays of ids and util.Rectangle instances for non-arrays.

i think we can simplify the logic quite a bit.

will give it a shot, but could use a review @ExtAnimal.

tobiu added the bug label on Sep 27, 2023, 8:19 PM
tobiu assigned to @tobiu on Sep 27, 2023, 8:19 PM
tobiu referenced in commit 846533c - "component.Base: getDomRect() => inconsistent return values #4950" on Sep 27, 2023, 8:20 PM
tobiu closed this issue on Sep 27, 2023, 8:20 PM
tobiu cross-referenced by #4951 on Sep 27, 2023, 8:35 PM
tobiu referenced in commit d91c921 - "v6.7.3 (#4954) on Sep 28, 2023, 12:55 PM
tobiu cross-referenced by #4892 on Oct 2, 2023, 11:34 AM