LearnNewsExamplesServices
Frontmatter
id4961
titlecombine Neo.merge() & core.Base: merge()
stateClosed
labels
enhancement
assigneestobiu
createdAtOct 2, 2023, 12:22 PM
updatedAtOct 2, 2023, 12:25 PM
githubUrlhttps://github.com/neomjs/neo/issues/4961
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 2, 2023, 12:25 PM

combine Neo.merge() & core.Base: merge()

Closed v8.1.0 enhancement
tobiu
tobiu commented on Oct 2, 2023, 12:22 PM

does not really make sense to have almost the same logic in 2 spots.

tobiu added the enhancement label on Oct 2, 2023, 12:22 PM
tobiu assigned to @tobiu on Oct 2, 2023, 12:22 PM
tobiu referenced in commit bf02153 - "combine Neo.merge() & core.Base: merge() #4961" on Oct 2, 2023, 12:23 PM
tobiu closed this issue on Oct 2, 2023, 12:23 PM
tobiu reopened this issue on Oct 2, 2023, 12:23 PM
tobiu
tobiu Oct 2, 2023, 12:24 PM

small oversight: while we could keep the inner this (pointing to Neo), using Neo feels cleaner.

tobiu referenced in commit bc466e6 - "#4961 cleanup" on Oct 2, 2023, 12:25 PM
tobiu closed this issue on Oct 2, 2023, 12:25 PM
tobiu referenced in commit a7f4765 - "v6.7.5 (#4962) on Oct 2, 2023, 12:30 PM