LearnNewsExamplesServices
Frontmatter
id500
titlebuildScripts/buildAll.js => add a check for build-dev & build-prod
stateClosed
labels
enhancementgood first issue
assignees[]
createdAtApr 21, 2020, 1:27 AM
updatedAtApr 22, 2020, 10:25 AM
githubUrlhttps://github.com/neomjs/neo/issues/500
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtApr 22, 2020, 10:25 AM

buildScripts/buildAll.js => add a check for build-dev & build-prod

Closed v1.1.47/archive-v1-1-47-chunk-1 enhancementgood first issue
tobiu
tobiu commented on Apr 21, 2020, 1:27 AM

those 2 scripts are not needed for apps (e.g. the covid dashboard app repo).

buildAll should grab the package.json and check if these 2 scripts exist and only then run

// neo dist versions => examples, docs app
cp.spawnSync(npmCmd, ['run', 'build-development'],        cpOpts);
cp.spawnSync(npmCmd, ['run', 'build-production'],         cpOpts);
tobiu added the enhancement label on Apr 21, 2020, 1:27 AM
tobiu added the good first issue label on Apr 21, 2020, 1:27 AM
tobiu cross-referenced by #3 on Apr 21, 2020, 1:28 AM
tobiu referenced in commit 96f2673 - "buildScripts/buildAll.js => add a check for build-dev & build-prod #500" on Apr 22, 2020, 10:09 AM
tobiu closed this issue on Apr 22, 2020, 10:25 AM