Frontmatter
| id | 5008 |
| title | dialog.Base: maximise is no longer animated |
| state | Closed |
| labels | buggood first issue |
| assignees | [] |
| createdAt | Oct 12, 2023, 8:07 AM |
| updatedAt | Aug 27, 2024, 11:15 PM |
| githubUrl | https://github.com/neomjs/neo/issues/5008 |
| author | tobiu |
| commentsCount | 2 |
| parentIssue | null |
| subIssues | [] |
| subIssuesCompleted | 0 |
| subIssuesTotal | 0 |
| blockedBy | [] |
| blocking | [] |
| closedAt | Aug 27, 2024, 11:15 PM |
dialog.Base: maximise is no longer animated
ExtAnimal
Oct 12, 2023, 8:20 AM
animate is too broad a name. This is to affect only whether maximize animates or not?
I suggest making maximizable a potentially granular config eg:
maximizable : true/false to enable and disable maximizing (and control the visibility of the button) in the basic case.
and
maximizable : {
animate : true
}
It's a truthy value, so it is maximizable. And it describe how to maximize.
This concept van be applied to many configs whose modes of operation is spread among several related configs.
tobiu
Aug 27, 2024, 11:15 PM
bug already fixed.
the maximise button is controlled via a header action. feel free to open a follow up ticket, in case we want to be able to maximise without an animation.
tobiu closed this issue on Aug 27, 2024, 11:15 PM
regression issue.
before removing the wrapper, we had the following CSS rule(s): https://github.com/neomjs/neo/blob/7c7d3bd794ab3f00845de69645dc0214feee4fab/resources/scss/src/dialog/Base.scss#L25
to do it in a good way, the dialog should get a new config called
animate_.animateTargetIdis still needed for spawn animations, but a more generic config to enable / disable all animations seems reasonable.afterSetAnimate()should add a new top level CSS rule likeneo-animatedwhich should contain similar rules to the old wrapper CSS.