LearnNewsExamplesServices
Frontmatter
id5209
titleNeo.applyClassConfig() => Neo.setupClass()
stateClosed
labels
enhancement
assignees[]
createdAtFeb 9, 2024, 1:14 PM
updatedAtFeb 20, 2024, 9:35 PM
githubUrlhttps://github.com/neomjs/neo/issues/5209
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtFeb 20, 2024, 9:35 PM

Neo.applyClassConfig() => Neo.setupClass()

Closed v8.1.0 enhancement
tobiu
tobiu commented on Feb 9, 2024, 1:14 PM

I actually like setupClass() better => shorter.

This is a breaking change though, so we should think about the renaming for the next major version.

tobiu added the enhancement label on Feb 9, 2024, 1:14 PM
tobiu referenced in commit aea9826 - "#5209 Neo.setupClass() => non-breaking PoC" on Feb 20, 2024, 9:25 PM
tobiu referenced in commit bdc2e49 - "#5209 Neo.setupClass() => changed all spots" on Feb 20, 2024, 9:30 PM
tobiu
tobiu Feb 20, 2024, 9:35 PM

found a non-breaking way to do it. applyClassConfig() will get deprecated in v8, but still works fine for now.

tobiu closed this issue on Feb 20, 2024, 9:35 PM
tobiu referenced in commit 0b7206f - "#5209 Neo.setupClass() => non-breaking PoC" on Mar 26, 2024, 5:29 PM
tobiu referenced in commit 945a070 - "#5209 Neo.setupClass() => changed all spots" on Mar 26, 2024, 5:29 PM