LearnNewsExamplesServices
Frontmatter
id5273
titlelist.Base: focus outlines are getting cut off
stateClosed
labels
bug
assigneestobiu
createdAtFeb 29, 2024, 11:10 AM
updatedAtFeb 29, 2024, 1:01 PM
githubUrlhttps://github.com/neomjs/neo/issues/5273
authortobiu
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtFeb 29, 2024, 11:19 AM

list.Base: focus outlines are getting cut off

Closed v8.1.0 bug
tobiu
tobiu commented on Feb 29, 2024, 11:10 AM

@ExtAnimal @mxmrtns

Screenshot 2024-02-29 at 11 04 56

the easiest solution for now is using outline-offset: -1px;.

we can create a follow-up ticket to discuss about other options (like removing overflow: hidden). however, this would be expensive regarding browser reflow OPs.

tobiu added the bug label on Feb 29, 2024, 11:10 AM
tobiu assigned to @tobiu on Feb 29, 2024, 11:10 AM
tobiu referenced in commit 22d8a2f - "list.Base: focus outlines are getting cut off #5273" on Feb 29, 2024, 11:18 AM
tobiu
tobiu Feb 29, 2024, 11:19 AM

added a new theme var to make it configurable: --list-item-focus-outline-offset

Screenshot 2024-02-29 at 11 19 36
tobiu closed this issue on Feb 29, 2024, 11:19 AM
mxmrtns
mxmrtns Feb 29, 2024, 1:01 PM

@tobiu This feels very much like a hack to me. I would rather add a padding with focus-outline-width. On the other hand can you put a number to what are the implications if we would get rid of overflow hidden? Like in ms?

tobiu referenced in commit 62969db - "list.Base: focus outlines are getting cut off #5273" on Mar 26, 2024, 5:29 PM