LearnNewsExamplesServices
Frontmatter
id5303
titleform.field.Text: inputValue_ config
stateClosed
labels
enhancement
assigneestobiu
createdAtMar 7, 2024, 12:34 PM
updatedAtMar 7, 2024, 2:52 PM
githubUrlhttps://github.com/neomjs/neo/issues/5303
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtMar 7, 2024, 2:43 PM

form.field.Text: inputValue_ config

Closed v8.1.0 enhancement
tobiu
tobiu commented on Mar 7, 2024, 12:34 PM

We need a sharp separation of inputValue and value, especially for class extensions like form.field.Select.

The first step is to implement it inside the TextField base class and then create follow-up tickets for class extensions.

@ExtAnimal

tobiu added the enhancement label on Mar 7, 2024, 12:34 PM
tobiu assigned to @tobiu on Mar 7, 2024, 12:34 PM
tobiu referenced in commit 4f4fb84 - "form.field.Text: inputValue_ config #5303" on Mar 7, 2024, 12:36 PM
tobiu referenced in commit 1a00391 - "#5303 form.field.Text: afterSetInputValue()" on Mar 7, 2024, 12:38 PM
tobiu referenced in commit fab4934 - "#5303 form.field.Text: onInputValueChange() => adjusted for the new config" on Mar 7, 2024, 12:47 PM
tobiu referenced in commit 3567d25 - "#5303 form.field.Text: afterSetInputValue() => moved the DOM update from afterSetValue() here" on Mar 7, 2024, 1:04 PM
tobiu referenced in commit 42569ea - "#5303 form.field.Text: updateInputValueFromValue(), updateValueFromInputValue()" on Mar 7, 2024, 2:31 PM
tobiu referenced in commit ab5837c - "#5303 form.field.Text: afterSetInputValue() => moved relevant css update logic from afterSetValue() here" on Mar 7, 2024, 2:34 PM
tobiu
tobiu Mar 7, 2024, 2:43 PM

the required changes are inside the TextField class now. before adjusting DateField, NumberField and SelectField, we need to write component tests for this class first: https://github.com/neomjs/neo/issues/5140

tobiu closed this issue on Mar 7, 2024, 2:43 PM
tobiu referenced in commit 7b73bcc - "form.field.Text: inputValue_ config #5303" on Mar 26, 2024, 5:29 PM
tobiu referenced in commit c494639 - "#5303 form.field.Text: afterSetInputValue()" on Mar 26, 2024, 5:29 PM
tobiu referenced in commit 9bd7bd2 - "#5303 form.field.Text: onInputValueChange() => adjusted for the new config" on Mar 26, 2024, 5:29 PM
tobiu referenced in commit ccace6f - "#5303 form.field.Text: afterSetInputValue() => moved the DOM update from afterSetValue() here" on Mar 26, 2024, 5:29 PM
tobiu referenced in commit 732b2bc - "#5303 form.field.Text: updateInputValueFromValue(), updateValueFromInputValue()" on Mar 26, 2024, 5:29 PM
tobiu referenced in commit 574b7c2 - "#5303 form.field.Text: afterSetInputValue() => moved relevant css update logic from afterSetValue() here" on Mar 26, 2024, 5:29 PM