LearnNewsExamplesServices
Frontmatter
id531
titleNeo.main.onDomContentLoaded: ensure the dynamic imports run in parallel
stateClosed
labels
enhancement
assigneestobiu
createdAtMay 3, 2020, 8:16 PM
updatedAtMay 3, 2020, 8:34 PM
githubUrlhttps://github.com/neomjs/neo/issues/531
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtMay 3, 2020, 8:34 PM

Neo.main.onDomContentLoaded: ensure the dynamic imports run in parallel

tobiu
tobiu commented on May 3, 2020, 8:16 PM
        if (Neo.config.useAmCharts) {
            await import(/* webpackChunkName: 'src/main/lib/AmCharts' */ './main/lib/AmCharts.mjs');
        }

        if (Neo.config.useMapboxGL) {
            await import(/* webpackChunkName: 'src/main/lib/MapboxGL' */ './main/lib/MapboxGL.mjs');
        }

this needs to switch to a promiseAll => we do not want to wait for each import to be finished before starting the next one.

on it.

tobiu added the enhancement label on May 3, 2020, 8:16 PM
tobiu assigned to @tobiu on May 3, 2020, 8:16 PM
tobiu referenced in commit d5faf8f - "Neo.main.onDomContentLoaded: ensure the dynamic imports run in parallel #531" on May 3, 2020, 8:27 PM
tobiu referenced in commit 13d4f7c - "#531 cleanup => no need to delay the inclusion of the GA script tag" on May 3, 2020, 8:33 PM
tobiu
tobiu May 3, 2020, 8:34 PM
Screenshot 2020-05-03 at 20 32 28
tobiu closed this issue on May 3, 2020, 8:34 PM