LearnNewsExamplesServices
Frontmatter
id5375
titlecollection.Base: destroy() => edge case, can get called more than once with VM based stores which get bound in multiple cmps.
stateClosed
labels
enhancement
assigneestobiu
createdAtMar 28, 2024, 10:56 AM
updatedAtMar 28, 2024, 2:57 PM
githubUrlhttps://github.com/neomjs/neo/issues/5375
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtMar 28, 2024, 2:57 PM

collection.Base: destroy() => edge case, can get called more than once with VM based stores which get bound in multiple cmps.

Closed v8.1.0 enhancement
tobiu
tobiu commented on Mar 28, 2024, 10:56 AM

i think core.Base: destroy() should set a flag like isDestroyed.

then all class extensions should check for this flag, before doing their logic.

thoughts? @ExtAnimal

tobiu added the enhancement label on Mar 28, 2024, 10:56 AM
tobiu assigned to @tobiu on Mar 28, 2024, 10:56 AM
tobiu referenced in commit 7b515ab - "collection.Base: destroy() => edge case, can get called more than once with VM based stores which get bound in multiple cmps. #5375" on Mar 28, 2024, 2:57 PM
tobiu closed this issue on Mar 28, 2024, 2:57 PM
tobiu referenced in commit d218dbf - "#5375 added a comment to explain why we are using an interceptor here" on Mar 28, 2024, 4:07 PM