LearnNewsExamplesServices
Frontmatter
id5390
titleform.field.ComboBox: does not hide the picker in case editable is false and opening it via a trigger click
stateClosed
labels
bug
assigneestobiu
createdAtApr 12, 2024, 12:57 PM
updatedAtApr 12, 2024, 12:57 PM
githubUrlhttps://github.com/neomjs/neo/issues/5390
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtApr 12, 2024, 12:57 PM

form.field.ComboBox: does not hide the picker in case editable is false and opening it via a trigger click

Closed v8.1.0 bug
tobiu
tobiu commented on Apr 12, 2024, 12:57 PM

@ExtAnimal

we have an override for onPickerTriggerClick() which does not honor the editable config.

inside form.field.Picker, we do have onInputClick(), which triggers togglePicker().

so, when editable is set to false, at first doFilter() gets called and then togglePicker(). it is a bit weird: after the show() call, a hide() call follows in real time. while i can not tell why the picker is not getting hidden right away, the hidden config does get changed to true. the result is that later hide() calls no longer work.

to fix this, i will just override togglePicker() to honor doFilter() and remove the onPickerTriggerClick() override. then editable true and false will both work again.

tobiu added the bug label on Apr 12, 2024, 12:57 PM
tobiu assigned to @tobiu on Apr 12, 2024, 12:57 PM
tobiu referenced in commit cdb3934 - "form.field.ComboBox: does not hide the picker in case editable is false and opening it via a trigger click #5390" on Apr 12, 2024, 12:57 PM
tobiu closed this issue on Apr 12, 2024, 12:57 PM