LearnNewsExamplesServices
Frontmatter
id5396
titleNeo.isRecord() does not work in dist/production
stateClosed
labels
bug
assigneestobiu
createdAtApr 16, 2024, 10:52 AM
updatedAtApr 16, 2024, 11:06 AM
githubUrlhttps://github.com/neomjs/neo/issues/5396
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtApr 16, 2024, 10:53 AM

Neo.isRecord() does not work in dist/production

Closed v8.1.0 bug
tobiu
tobiu commented on Apr 16, 2024, 10:52 AM
    static isRecord(value) {
        return value?.constructor?.name === 'Record' || false
    }

While we could change the logic to: item.isRecord (we do set a custom flag), the ctor name does get minified.

Since we are not minifying neo classNames I would argue that we should also not minify the name "Record", to give devs better chances of debugging inside dist/prod when needed.

tobiu added the bug label on Apr 16, 2024, 10:52 AM
tobiu assigned to @tobiu on Apr 16, 2024, 10:52 AM
tobiu referenced in commit 42592c6 - "Neo.isRecord() does not work in dist/production #5396" on Apr 16, 2024, 10:53 AM
tobiu closed this issue on Apr 16, 2024, 10:53 AM