LearnNewsExamplesServices
Frontmatter
id5429
titletab.Container: getLayoutConfig() => replace the switch block with an object (map)
stateClosed
labels
enhancementgood first issuestale
assignees[]
createdAtJun 21, 2024, 9:55 PM
updatedAtJan 15, 2025, 3:28 AM
githubUrlhttps://github.com/neomjs/neo/issues/5429
authortobiu
commentsCount7
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJan 15, 2025, 3:28 AM

tab.Container: getLayoutConfig() => replace the switch block with an object (map)

Closed v8.5.0 enhancementgood first issuestale
tobiu
tobiu commented on Jun 21, 2024, 9:55 PM

(No description provided)

tobiu added the enhancement label on Jun 21, 2024, 9:55 PM
tobiu added the good first issue label on Jun 21, 2024, 9:55 PM
TheCoderAdi cross-referenced by PR #5978 on Sep 29, 2024, 7:47 AM
TheCoderAdi
TheCoderAdi Sep 29, 2024, 7:49 AM

Hello , I have added a pull request for it , Please review the changes and add a label for hacktoberfest2024

tobiu
tobiu Sep 29, 2024, 1:10 PM

hi @TheCoderAdi!

the PR looks fine to me. I just took another look into the hacktoberfest rules, and if i understand them correctly, only PRs starting from October 1 count. If I am right on this one, you should re-send the PR on Tuesday, to ensure that you get the events credits.

Best regards, Tobias

TheCoderAdi
TheCoderAdi Sep 29, 2024, 1:20 PM

Thank you for taking the time to review my PR! I really appreciate your feedback.

I'll hold off on any further pull/merge requests until October so they can count toward the event.

Looking forward to contributing once it starts!

Best regards, Aditya Swayamsiddha

On Sun, Sep 29, 2024, 4:41 PM Tobias Uhlig @.***> wrote:

hi @TheCoderAdi https://github.com/TheCoderAdi!

the PR looks fine to me. I just took another look into the hacktoberfest rules, and if i understand them correctly, only PRs starting from October 1 count. If I am right on this one, you should re-send the PR on Tuesday, to ensure that you get the events credits.

Best regards, Tobias

— Reply to this email directly, view it on GitHub https://github.com/neomjs/neo/issues/5429#issuecomment-2381315064, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2RBJLTSQUCOX4DNI2TFS7LZY7N4XAVCNFSM6AAAAABJWVH5HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGMYTKMBWGQ . You are receiving this because you were mentioned.Message ID: @.***>

  • 2024-09-30T02:39:24Z @github-actions removed the stale label
TheCoderAdi cross-referenced by PR #5995 on Oct 1, 2024, 3:43 AM
TheCoderAdi
TheCoderAdi Oct 1, 2024, 7:03 AM

I hope you're doing well! Since Hacktoberfest has officially started, I wanted to kindly request if you could merge the pull request I recently submitted. This will allow the contribution to count towards the event, and I'd be thrilled to see it make a positive impact.

Thank you for your time and support!

@github-actions - 2024-12-31T02:31:02Z

This issue is stale because it has been open for 90 days with no activity.

  • 2024-12-31T02:31:02Z @github-actions added the stale label

@github-actions - 2025-01-15T02:28:58Z

This issue was closed because it has been inactive for 14 days since being marked as stale.

  • 2025-01-15T02:28:59Z @github-actions closed this issue