LearnNewsExamplesServices
Frontmatter
id5461
titleplugin.Responsive: remove Neo.Responsive
stateClosed
labels
enhancementstale
assigneesDinkh
createdAtJun 23, 2024, 10:36 AM
updatedAtOct 6, 2024, 4:38 AM
githubUrlhttps://github.com/neomjs/neo/issues/5461
authortobiu
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 6, 2024, 4:38 AM

plugin.Responsive: remove Neo.Responsive

Closed v8.1.0 enhancementstale
tobiu
tobiu commented on Jun 23, 2024, 10:36 AM

without doing a deep dive, using Neo.Responsive feels like a namespace pollution.

in case we want to share data across all instances of the plugin, we can either use a static class field or define a variable inside the module (e.g. on top of the class definition).

it kind of depends if we want to provide access to the data outside of the plugin. but even if so, we should expose a getter method inside the plugin to do this.

tobiu added the enhancement label on Jun 23, 2024, 10:36 AM
tobiu assigned to @Dinkh on Jun 23, 2024, 10:36 AM