LearnNewsExamplesServices
Frontmatter
id5482
titleLivePreview: closing a detached window sometimes gets an error
stateClosed
labels
bug
assigneestobiu
createdAtJun 24, 2024, 10:27 PM
updatedAtJun 26, 2024, 9:53 AM
githubUrlhttps://github.com/neomjs/neo/issues/5482
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJun 26, 2024, 9:53 AM

LivePreview: closing a detached window sometimes gets an error

Closed v8.1.0 bug
tobiu
tobiu commented on Jun 24, 2024, 10:27 PM

Screenshot 2024-06-24 at 22 25 48

might be a bigger issue: revertFocus() & focus() could not be aware about different windows or a focus call wants to enter a no longer existing window.

tobiu added the bug label on Jun 24, 2024, 10:27 PM
tobiu assigned to @tobiu on Jun 24, 2024, 10:27 PM
tobiu referenced in commit 7180539 - "LivePreview: closing a detached window sometimes gets an error #5482" on Jun 26, 2024, 9:51 AM
tobiu
tobiu Jun 26, 2024, 9:53 AM

while there was an issue with the focus remote call (passing id instead of window id, i added explicit port checks into worker.Base. if a windowId gets passed and no port it found, no message will get send. accordingly: promiseMessage() will directly trigger reject() if no message was sent.

tobiu closed this issue on Jun 26, 2024, 9:53 AM