LearnNewsExamplesServices
Frontmatter
id5495
titledialog.Base: centering logic
stateClosed
labels
enhancement
assigneestobiu
createdAtJun 29, 2024, 6:03 PM
updatedAtJun 29, 2024, 6:17 PM
githubUrlhttps://github.com/neomjs/neo/issues/5495
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJun 29, 2024, 6:17 PM

dialog.Base: centering logic

Closed v8.1.0 enhancement
tobiu
tobiu commented on Jun 29, 2024, 6:03 PM

it is time to get rid of:

    &.neo-centered {
        left      : 50%;
        top       : 50%;
        transform : translate(-50%, -50%);
    }

by default, a position: fixed div should already be centered.

however, the logic of animateShow() needs to grab the size of the offscreen rendered dialog & document body, to animate it to a calculated centered position.

tobiu added the enhancement label on Jun 29, 2024, 6:03 PM
tobiu assigned to @tobiu on Jun 29, 2024, 6:03 PM
tobiu referenced in commit c133791 - "dialog.Base: centering logic #5495" on Jun 29, 2024, 6:06 PM
tobiu referenced in commit 8736e4a - "#5495 dialog.Base: removing the centered_ config" on Jun 29, 2024, 6:07 PM
tobiu closed this issue on Jun 29, 2024, 6:17 PM