LearnNewsExamplesServices
Frontmatter
id5636
titledialog.Base: header styling inside theme-neo-light
stateClosed
labels
enhancement
assigneestobiu
createdAtJul 28, 2024, 4:59 PM
updatedAtJul 28, 2024, 5:13 PM
githubUrlhttps://github.com/neomjs/neo/issues/5636
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJul 28, 2024, 5:13 PM

dialog.Base: header styling inside theme-neo-light

Closed v8.1.0 enhancement
tobiu
tobiu commented on Jul 28, 2024, 4:59 PM

@mxmrtns

Inside theme-light dialogs look like this:

Screenshot 2024-07-28 at 16 54 38

Inside our new theme the styling is still missing:

Screenshot 2024-07-28 at 16 54 29

For now, I will just add overrides into the theme based scss file to make it look a bit more reasonable.

We can create follow-up tickets, in case the header toolbar should keep a bigger height.

tobiu added the enhancement label on Jul 28, 2024, 4:59 PM
tobiu assigned to @tobiu on Jul 28, 2024, 4:59 PM
tobiu referenced in commit a67b7ad - "dialog.Base: header styling inside theme-neo-light #5636" on Jul 28, 2024, 5:10 PM
tobiu referenced in commit 9855cff - "#5636 using core tokens for colors" on Jul 28, 2024, 5:13 PM
tobiu
tobiu Jul 28, 2024, 5:13 PM

Screenshot 2024-07-28 at 17 13 17

tobiu closed this issue on Jul 28, 2024, 5:13 PM