LearnNewsExamplesServices
Frontmatter
id565
titlemain.addon.HighlightJS => load script order
stateClosed
labels
enhancement
assigneestobiu
createdAtMay 19, 2020, 8:12 PM
updatedAtMay 19, 2020, 8:16 PM
githubUrlhttps://github.com/neomjs/neo/issues/565
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtMay 19, 2020, 8:16 PM

main.addon.HighlightJS => load script order

tobiu
tobiu commented on May 19, 2020, 8:12 PM

i noticed that sometimes the hljs linenumbers file does load faster than the hljs lib. this is a problem, since linenumbers does not work in case hljs is not already there.

we need to replace addScript with the promise based loadScript() and use then() to load the line-numbers.

tobiu added the enhancement label on May 19, 2020, 8:12 PM
tobiu assigned to @tobiu on May 19, 2020, 8:12 PM
tobiu referenced in commit 6652d73 - "main.addon.HighlightJS => load script order #565" on May 19, 2020, 8:15 PM
tobiu closed this issue on May 19, 2020, 8:16 PM