LearnNewsExamplesServices
Frontmatter
id5675
titlecomponent.Video: errorMsg config
stateClosed
labels
bug
assigneesDinkh
createdAtAug 3, 2024, 8:32 PM
updatedAtAug 10, 2024, 6:32 PM
githubUrlhttps://github.com/neomjs/neo/issues/5675
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtAug 10, 2024, 6:32 PM

component.Video: errorMsg config

Closed v8.1.0 bug
tobiu
tobiu commented on Aug 3, 2024, 8:32 PM

Defined as a boolean instead of a string.

    afterSetUrl(value, oldValue) {
        if (!value) return;

        let {vdom} = this,
            media = VDomUtil.getFlags(vdom, 'media')[0];

        media.cn = [{
            tag: 'source',
            src: value,
            type: this.type
        }, {
            tag: 'span',
            html: this.errorMsg,
        }];

        this.update()
    }

Why would you always drop in an error message for all browsers?

Except for Opera Mini, all browsers can handle it: https://caniuse.com/video

So we should not add not needed DOM nodes for others.

tobiu added the bug label on Aug 3, 2024, 8:32 PM
tobiu assigned to @Dinkh on Aug 3, 2024, 8:32 PM
Dinkh
Dinkh Aug 10, 2024, 6:32 PM

updated

Dinkh closed this issue on Aug 10, 2024, 6:32 PM