LearnNewsExamplesServices
Frontmatter
id5676
titlecomponent.Video: handleAutoplay() => redundant update() call
stateClosed
labels
bug
assigneesDinkh
createdAtAug 3, 2024, 8:40 PM
updatedAtAug 10, 2024, 6:22 PM
githubUrlhttps://github.com/neomjs/neo/issues/5676
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtAug 10, 2024, 6:22 PM

component.Video: handleAutoplay() => redundant update() call

Closed v8.1.0 bug
tobiu
tobiu commented on Aug 3, 2024, 8:40 PM

If I see it correctly, handleAutoplay() only gets called inside construct(). If so, the method needs the @protected flag.

It is using this.update() before changing the value of the playing config, which itself also triggers an update() call.

We really want to batch all changes into one update() call instead => removing it inside handleAutoplay() would be sufficient.

Rationale: update() sends the vdom & vnode on a workers roundtrip to get the deltas. While this is happening, the component locks itself for future updates until the new vnode got back (async). After the delay the framework would trigger a 2nd roundtrip to get the deltas for the visible node.

tobiu added the bug label on Aug 3, 2024, 8:40 PM
tobiu assigned to @Dinkh on Aug 3, 2024, 8:40 PM
Dinkh
Dinkh Aug 10, 2024, 6:22 PM

understood and fixed

Dinkh closed this issue on Aug 10, 2024, 6:22 PM