Frontmatter
| id | 5677 |
| title | component.Video: remove beforeSetPlaying() |
| state | Closed |
| labels | enhancement |
| assignees | Dinkh |
| createdAt | Aug 3, 2024, 8:45 PM |
| updatedAt | Aug 10, 2024, 6:17 PM |
| githubUrl | https://github.com/neomjs/neo/issues/5677 |
| author | tobiu |
| commentsCount | 1 |
| parentIssue | null |
| subIssues | [] |
| subIssuesCompleted | 0 |
| subIssuesTotal | 0 |
| blockedBy | [] |
| blocking | [] |
| closedAt | Aug 10, 2024, 6:17 PM |

beforeSetPlaying(value, oldValue) { if (!Neo.isBoolean(value)) { return oldValue } return value }Validating a boolean on class level is pointless. Doing a check for specific enum values is fine, but when it comes to base types, this is way over the top. Imagine we would add
beforeSetX()for every possible boolean, number or string config inside the framework.We can think about generic config type checkings, but this is not the way to go.