LearnNewsExamplesServices
Frontmatter
id5806
titlecode.LivePreview: we must use the return value of Neo.setupClass()
stateClosed
labels
enhancement
assigneestobiu
createdAtAug 19, 2024, 7:38 PM
updatedAtAug 19, 2024, 7:40 PM
githubUrlhttps://github.com/neomjs/neo/issues/5806
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtAug 19, 2024, 7:38 PM

code.LivePreview: we must use the return value of Neo.setupClass()

Closed v8.1.0 enhancement
tobiu
tobiu commented on Aug 19, 2024, 7:38 PM

related to the changes which enable us to use multiple neo versions & envs in parallel.

setupClass() will no longer parse input with the same className multiple times, but return the first found match instead.

this also affects our live previews: while the first switch to the preview mode did still work fine. switching back & forth did not:

Screenshot 2024-08-19 at 19 35 25

tobiu added the enhancement label on Aug 19, 2024, 7:38 PM
tobiu assigned to @tobiu on Aug 19, 2024, 7:38 PM
tobiu referenced in commit 63750ab - "code.LivePreview: we must use the return value of Neo.setupClass() #5806" on Aug 19, 2024, 7:38 PM
tobiu closed this issue on Aug 19, 2024, 7:38 PM
tobiu
tobiu Aug 19, 2024, 7:40 PM

@maxrahder: fyi for future live previews or in case you are wondering what happened.