LearnNewsExamplesServices
Frontmatter
id5822
titlemain.addon.MonacoEditor: remove editor/editor.main.nls.js
stateOpen
labels
bugenhancementno auto close
assigneestobiu
createdAtAug 26, 2024, 8:35 PM
updatedAtMay 16, 2026, 10:50 PM
githubUrlhttps://github.com/neomjs/neo/issues/5822
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]

main.addon.MonacoEditor: remove editor/editor.main.nls.js

Openbugenhancementno auto close
tobiu
tobiu commented on Aug 26, 2024, 8:35 PM

i upgraded to v0.51.0, and was missing that the setup changed.

the breaking change was not mentioned inside the release notes: https://github.com/microsoft/monaco-editor/releases/tag/v0.51.0

i found it here: https://github.com/microsoft/monaco-editor/commit/e52ff427290808dff6809b3f77866ae7a62a119b

tobiu added the enhancement label on Aug 26, 2024, 8:35 PM
tobiu assigned to @tobiu on Aug 26, 2024, 8:35 PM
tobiu added the bug label on Aug 26, 2024, 8:42 PM
tobiu
tobiu Aug 26, 2024, 8:44 PM

tried it out with removing the file, and it is causing serious damage:

Screenshot 2024-08-26 at 20 41 32

i will switch back to the previous version and create a bug ticket for microsoft.

tobiu cross-referenced by #4654 on Aug 26, 2024, 8:50 PM
tobiu referenced in commit 97c9ffb - "#5822 switching back to the last stable monaco-editor version for now" on Aug 26, 2024, 8:52 PM
tobiu added the no auto close label on Aug 27, 2024, 10:40 PM