Frontmatter
| id | 5848 |
| title | theme-neo-light: splitter styling |
| state | Closed |
| labels | bug |
| assignees | tobiu |
| createdAt | Sep 1, 2024, 1:53 PM |
| updatedAt | Sep 1, 2024, 2:31 PM |
| githubUrl | https://github.com/neomjs/neo/issues/5848 |
| author | tobiu |
| commentsCount | 1 |
| parentIssue | null |
| subIssues | [] |
| subIssuesCompleted | 0 |
| subIssuesTotal | 0 |
| blockedBy | [] |
| blocking | [] |
| closedAt | Sep 1, 2024, 2:31 PM |
theme-neo-light: splitter styling
tobiu assigned to @tobiu on Sep 1, 2024, 1:53 PM
tobiu
Sep 1, 2024, 2:31 PM
i changed my mind and did the follow-up part right away.
3 new theming vars for all themes:
--splitter-border-radius : 5px;
--splitter-margin-horizontal: 2px 8px;
--splitter-margin-vertical : 8px 2px;
the positioning bug was easy to fix: getBoundingClientRect() already adds margins to positions, so it would get added twice unless we nullify it for the proxy.
look into the last commit for details.
tobiu closed this issue on Sep 1, 2024, 2:31 PM
some custom overrides got into the splitter styling which are problematic:
.neo-splitter { opacity: 1; margin: 8px 2px; border-radius: 100px; border: unset !important; &:hover, &:active { background-color: #5595F5 !important; } } .neo-dragproxy { &.neo-splitter { background-color: #5595F5 !important; } }while the design might be ok for vertical splitters, the margin will look odd for horizontal ones.
another problem is that the dragProxy logic does not honor it yet:
so dragging moves the content too far to the bottom.
i will move the possible changes into the theme vars and remove the margin for now.
@mxmrtns: please create a new ticket in case you would like to see a proper implementation for border-radius & margins.